Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-1397] Incorporate unused 0.8.2 improvements #11

Draft
wants to merge 43 commits into
base: 0-8-stable
Choose a base branch
from

Conversation

dlozano
Copy link

@dlozano dlozano commented Jun 25, 2024

dugjason and others added 30 commits October 20, 2015 00:12
…Ensure we wind to beginning of business day when using business_hours before/after methods
Fixes for issues bokmann#36, bokmann#45 and bokmann#83 (bug in business_days.before/after)
Update bundler before travis builds
…ss_days_until

Adds support for inclusive results from business_days_until() method
I love this feature!  Why didn't I know this existed before?
I didn't really need to do this, but it served as a useful example.
Really, I'm just testing to see if the git status hooks actually do
something useful.
Updates Activesupport version and internal version prepping for release.
When you use Time.parse, you get a Time object back; when
you use Time.zone.parse, you get a TimeWithZone. The code
should preserve the timezone _on this time object_, not
re-apply Time.zone, which can change independently of time
objects.

Added to the misnamed business_time_until_eastern test to demonstrate
that timezone is preserved in both Time and TimeWithZone objects;
fixed a failing test in test_calculating_business_duration
that wrongly assumed that Time.parse objects should follow
Time.zone.
…PT-3440-merge-official-develop

Conflicts:
	Gemfile.lock
	business_time.gemspec
	lib/business_time/business_days.rb
	lib/business_time/core_ext/date.rb
	lib/business_time/version.rb
	test/test_business_time_until_eastern.rb
Base automatically changed from feature/SR-1396-add-ci-and-loosen-activesupport-requirement to 0-8-stable June 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants